Remove unneeded isloading attribute #8340

roykho · 2023-01-30T21:43:45Z

This PR fixes a console error Warning: React does not recognize the isLoadingprop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercaseisloading instead. If you accidentally passed it from a parent component, remove it from the DOM element. when the Filter by Price block is used. You can see this error in the front and backend editor. It turns out isLoading isn't needed/expected for FormattedMonetaryAmount component.

Testing

User Facing Testing

Checkout this branch.
Go to admin dashboard->page and create a new page.
Add the Filter by Price block while looking at the console. There shouldn't be any errors seen regarding isLoading.

Do not include in the Testing Notes

Performance Impact

Changelog

Fix console error of isLoading for Price filter block.

github-actions · 2023-01-30T21:45:44Z

The release ZIP for this PR is accessible via:

https://wcblocks.wpcomstaging.com/wp-content/uploads/woocommerce-gutenberg-products-block-8340.zip

Script Dependencies Report

The compare-assets action has detected some changed script dependencies between this branch and trunk. Please review and confirm the following are correct before merging.

Script Handle	Added
`reviews-frontend.js`	`react`, `wc-settings`, `wp-a11y`, `wp-api-fetch`, `wp-compose`, `wp-element`, `wp-i18n`, `wp-is-shallow-equal`, `wp-polyfill`	⚠️
`active-filters-frontend.js`	`lodash`, `react`, `wc-blocks-data-store`, `wc-price-format`, `wc-settings`, `wp-data`, `wp-element`, `wp-html-entities`, `wp-i18n`, `wp-is-shallow-equal`, `wp-polyfill`, `wp-primitives`, `wp-url`	⚠️
`all-products-frontend.js`	`lodash`, `react`, `wc-blocks-checkout`, `wc-blocks-data-store`, `wc-blocks-registry`, `wc-blocks-shared-context`, `wc-blocks-shared-hocs`, `wc-price-format`, `wc-settings`, `wp-a11y`, `wp-api-fetch`, `wp-autop`, `wp-block-editor`, `wp-blocks`, `wp-compose`, `wp-data`, `wp-deprecated`, `wp-dom`, `wp-element`, `wp-hooks`, `wp-html-entities`, `wp-i18n`, `wp-is-shallow-equal`, `wp-polyfill`, `wp-primitives`, `wp-url`, `wp-warning`, `wp-wordcount`	⚠️
`attribute-filter-frontend.js`	`lodash`, `react`, `wc-blocks-checkout`, `wc-blocks-data-store`, `wc-settings`, `wp-a11y`, `wp-block-editor`, `wp-blocks`, `wp-compose`, `wp-data`, `wp-deprecated`, `wp-dom`, `wp-element`, `wp-html-entities`, `wp-i18n`, `wp-is-shallow-equal`, `wp-keycodes`, `wp-polyfill`, `wp-primitives`, `wp-url`, `wp-warning`	⚠️
`cart-frontend.js`	`lodash`, `react`, `wc-blocks-checkout`, `wc-blocks-data-store`, `wc-blocks-registry`, `wc-blocks-shared-context`, `wc-blocks-shared-hocs`, `wc-price-format`, `wc-settings`, `wp-a11y`, `wp-api-fetch`, `wp-autop`, `wp-block-editor`, `wp-blocks`, `wp-compose`, `wp-data`, `wp-deprecated`, `wp-dom`, `wp-element`, `wp-hooks`, `wp-html-entities`, `wp-i18n`, `wp-is-shallow-equal`, `wp-keycodes`, `wp-plugins`, `wp-polyfill`, `wp-primitives`, `wp-url`, `wp-warning`, `wp-wordcount`	⚠️
`checkout-frontend.js`	`lodash`, `react`, `wc-blocks-checkout`, `wc-blocks-data-store`, `wc-blocks-registry`, `wc-blocks-shared-hocs`, `wc-price-format`, `wc-settings`, `wp-a11y`, `wp-api-fetch`, `wp-autop`, `wp-compose`, `wp-data`, `wp-deprecated`, `wp-dom`, `wp-element`, `wp-hooks`, `wp-html-entities`, `wp-i18n`, `wp-is-shallow-equal`, `wp-keycodes`, `wp-plugins`, `wp-polyfill`, `wp-primitives`, `wp-url`, `wp-warning`, `wp-wordcount`	⚠️
`filter-wrapper-frontend.js`	`lodash`, `react`, `wc-blocks-checkout`, `wc-blocks-data-store`, `wc-blocks-registry`, `wc-price-format`, `wc-settings`, `wp-a11y`, `wp-block-editor`, `wp-blocks`, `wp-compose`, `wp-data`, `wp-deprecated`, `wp-dom`, `wp-element`, `wp-html-entities`, `wp-i18n`, `wp-is-shallow-equal`, `wp-keycodes`, `wp-polyfill`, `wp-primitives`, `wp-url`, `wp-warning`	⚠️
`mini-cart-frontend.js`	`wc-settings`, `wp-polyfill`	⚠️
`price-filter-frontend.js`	`lodash`, `react`, `wc-blocks-data-store`, `wc-price-format`, `wc-settings`, `wp-data`, `wp-element`, `wp-i18n`, `wp-is-shallow-equal`, `wp-polyfill`, `wp-url`	⚠️
`rating-filter-frontend.js`	`lodash`, `react`, `wc-blocks-checkout`, `wc-blocks-data-store`, `wc-settings`, `wp-a11y`, `wp-block-editor`, `wp-blocks`, `wp-compose`, `wp-data`, `wp-deprecated`, `wp-dom`, `wp-element`, `wp-i18n`, `wp-is-shallow-equal`, `wp-keycodes`, `wp-polyfill`, `wp-primitives`, `wp-url`, `wp-warning`	⚠️
`single-product-frontend.js`	`lodash`, `react`, `wc-blocks-checkout`, `wc-blocks-data-store`, `wc-blocks-registry`, `wc-blocks-shared-context`, `wc-blocks-shared-hocs`, `wc-price-format`, `wc-settings`, `wp-api-fetch`, `wp-autop`, `wp-block-editor`, `wp-blocks`, `wp-compose`, `wp-data`, `wp-deprecated`, `wp-dom`, `wp-element`, `wp-hooks`, `wp-html-entities`, `wp-i18n`, `wp-is-shallow-equal`, `wp-polyfill`, `wp-primitives`, `wp-url`, `wp-warning`, `wp-wordcount`	⚠️
`stock-filter-frontend.js`	`lodash`, `react`, `wc-blocks-checkout`, `wc-blocks-data-store`, `wc-settings`, `wp-a11y`, `wp-block-editor`, `wp-blocks`, `wp-compose`, `wp-data`, `wp-deprecated`, `wp-dom`, `wp-element`, `wp-html-entities`, `wp-i18n`, `wp-is-shallow-equal`, `wp-keycodes`, `wp-polyfill`, `wp-primitives`, `wp-url`, `wp-warning`	⚠️
`mini-cart-component-frontend.js`	`lodash`, `react`, `wc-blocks-checkout`, `wc-blocks-data-store`, `wc-blocks-registry`, `wc-price-format`, `wc-settings`, `wp-a11y`, `wp-autop`, `wp-compose`, `wp-data`, `wp-deprecated`, `wp-dom`, `wp-element`, `wp-hooks`, `wp-html-entities`, `wp-i18n`, `wp-is-shallow-equal`, `wp-keycodes`, `wp-polyfill`, `wp-primitives`, `wp-url`, `wp-warning`, `wp-wordcount`	⚠️

This comment was automatically generated by the ./github/compare-assets action.

TypeScript Errors Report

Files with errors: 503
Total errors: 2346

🎉 🎉 This PR does not introduce new TS errors.

_{comments-aggregator}

github-actions · 2023-01-30T21:51:37Z

Size Change: -16 B (0%)

Total Size: 1.1 MB

Filename	Size	Change
`build/price-filter-frontend.js`	13.8 kB	-3 B (0%)
`build/price-filter-wrapper-frontend.js`	6.97 kB	-5 B (0%)
`build/price-filter.js`	8.36 kB	-8 B (0%)

ℹ️ View Unchanged

Filename	Size
`build/active-filters-frontend.js`	7.98 kB
`build/active-filters-wrapper-frontend.js`	6 kB
`build/active-filters.js`	7.29 kB
`build/all-products-frontend.js`	11.7 kB
`build/all-products.js`	33.7 kB
`build/all-reviews.js`	7.67 kB
`build/attribute-filter-frontend.js`	22.9 kB
`build/attribute-filter-wrapper-frontend.js`	7.66 kB
`build/attribute-filter.js`	12.3 kB
`build/blocks-checkout.js`	41 kB
`build/breadcrumbs.js`	1.51 kB
`build/cart-blocks/cart-accepted-payment-methods-frontend.js`	1.38 kB
`build/cart-blocks/cart-cross-sells-frontend.js`	253 B
`build/cart-blocks/cart-cross-sells-products-frontend.js`	9.64 kB
`build/cart-blocks/cart-express-payment--checkout-blocks/express-payment-frontend.js`	5.08 kB
`build/cart-blocks/cart-express-payment-frontend.js`	720 B
`build/cart-blocks/cart-items-frontend.js`	299 B
`build/cart-blocks/cart-line-items--mini-cart-contents-block/products-table-frontend.js`	5.37 kB
`build/cart-blocks/cart-line-items-frontend.js`	1.07 kB
`build/cart-blocks/cart-order-summary-frontend.js`	1.25 kB
`build/cart-blocks/cart-totals-frontend.js`	321 B
`build/cart-blocks/empty-cart-frontend.js`	345 B
`build/cart-blocks/filled-cart-frontend.js`	656 B
`build/cart-blocks/order-summary-coupon-form-frontend.js`	1.63 kB
`build/cart-blocks/order-summary-discount-frontend.js`	2.13 kB
`build/cart-blocks/order-summary-fee-frontend.js`	274 B
`build/cart-blocks/order-summary-heading-frontend.js`	456 B
`build/cart-blocks/order-summary-shipping-frontend.js`	14.9 kB
`build/cart-blocks/order-summary-subtotal-frontend.js`	274 B
`build/cart-blocks/order-summary-taxes-frontend.js`	435 B
`build/cart-blocks/proceed-to-checkout-frontend.js`	1.24 kB
`build/cart-frontend.js`	28.6 kB
`build/cart.js`	47.6 kB
`build/catalog-sorting.js`	1.69 kB
`build/checkout-blocks/actions-frontend.js`	1.85 kB
`build/checkout-blocks/billing-address--checkout-blocks/shipping-address-frontend.js`	3.92 kB
`build/checkout-blocks/billing-address-frontend.js`	1.16 kB
`build/checkout-blocks/contact-information-frontend.js`	2.05 kB
`build/checkout-blocks/express-payment-frontend.js`	1.13 kB
`build/checkout-blocks/fields-frontend.js`	344 B
`build/checkout-blocks/order-note-frontend.js`	1.14 kB
`build/checkout-blocks/order-summary-cart-items-frontend.js`	3.68 kB
`build/checkout-blocks/order-summary-coupon-form-frontend.js`	1.79 kB
`build/checkout-blocks/order-summary-discount-frontend.js`	2.3 kB
`build/checkout-blocks/order-summary-fee-frontend.js`	277 B
`build/checkout-blocks/order-summary-frontend.js`	1.25 kB
`build/checkout-blocks/order-summary-shipping-frontend.js`	14.9 kB
`build/checkout-blocks/order-summary-subtotal-frontend.js`	275 B
`build/checkout-blocks/order-summary-taxes-frontend.js`	435 B
`build/checkout-blocks/payment-frontend.js`	8.33 kB
`build/checkout-blocks/pickup-options-frontend.js`	2.81 kB
`build/checkout-blocks/shipping-address-frontend.js`	1.12 kB
`build/checkout-blocks/shipping-method-frontend.js`	2.27 kB
`build/checkout-blocks/shipping-methods-frontend.js`	4.83 kB
`build/checkout-blocks/terms-frontend.js`	1.56 kB
`build/checkout-blocks/totals-frontend.js`	324 B
`build/checkout-frontend.js`	30.2 kB
`build/checkout.js`	43.4 kB
`build/customer-account.js`	3.08 kB
`build/featured-category.js`	13.2 kB
`build/featured-product.js`	13.4 kB
`build/filter-wrapper-frontend.js`	14 kB
`build/filter-wrapper.js`	2.4 kB
`build/general-style-rtl.css`	1.31 kB
`build/general-style.css`	1.31 kB
`build/handpicked-products.js`	7.24 kB
`build/legacy-template.js`	2.87 kB
`build/mini-cart-component-frontend.js`	27.9 kB
`build/mini-cart-contents-block/empty-cart-frontend.js`	366 B
`build/mini-cart-contents-block/filled-cart-frontend.js`	268 B
`build/mini-cart-contents-block/footer-frontend.js`	2.82 kB
`build/mini-cart-contents-block/items-frontend.js`	237 B
`build/mini-cart-contents-block/products-table-frontend.js`	590 B
`build/mini-cart-contents-block/shopping-button-frontend.js`	313 B
`build/mini-cart-contents-block/title-frontend.js`	367 B
`build/mini-cart-contents.js`	17 kB
`build/mini-cart-frontend.js`	2 kB
`build/mini-cart.js`	4.29 kB
`build/price-format.js`	1.19 kB
`build/product-add-to-cart--product-button--product-category-list--product-image--product-price--product-r--a0326d00.js`	227 B
`build/product-add-to-cart--product-button--product-image--product-rating--product-title.js`	151 B
`build/product-add-to-cart-frontend.js`	6.71 kB
`build/product-add-to-cart.js`	8.62 kB
`build/product-best-sellers.js`	7.61 kB
`build/product-button--product-category-list--product-image--product-price--product-rating--product-sale-b--e17c7c01.js`	439 B
`build/product-button--product-image--product-price--product-rating--product-sale-badge--product-title.js`	258 B
`build/product-button-frontend.js`	2.14 kB
`build/product-button.js`	3.99 kB
`build/product-categories.js`	2.36 kB
`build/product-category-list-frontend.js`	1.14 kB
`build/product-category-list.js`	503 B
`build/product-category.js`	8.6 kB
`build/product-image-frontend.js`	2.14 kB
`build/product-image.js`	4.09 kB
`build/product-new.js`	7.6 kB
`build/product-on-sale.js`	7.92 kB
`build/product-price-frontend.js`	2.23 kB
`build/product-price.js`	1.58 kB
`build/product-query.js`	5.92 kB
`build/product-rating-frontend.js`	1.57 kB
`build/product-rating.js`	920 B
`build/product-results-count.js`	1.66 kB
`build/product-sale-badge-frontend.js`	1.37 kB
`build/product-sale-badge.js`	812 B
`build/product-search.js`	2.6 kB
`build/product-sku-frontend.js`	629 B
`build/product-sku.js`	378 B
`build/product-stock-indicator-frontend.js`	1.26 kB
`build/product-stock-indicator.js`	646 B
`build/product-summary-frontend.js`	1.53 kB
`build/product-summary.js`	920 B
`build/product-tag-list-frontend.js`	1.13 kB
`build/product-tag-list.js`	497 B
`build/product-tag.js`	8.08 kB
`build/product-title-frontend.js`	1.57 kB
`build/product-title.js`	3.46 kB
`build/product-top-rated.js`	7.84 kB
`build/products-by-attribute.js`	8.52 kB
`build/rating-filter-frontend.js`	21.4 kB
`build/rating-filter-wrapper-frontend.js`	6.2 kB
`build/rating-filter.js`	7.41 kB
`build/reviews-by-category.js`	11.2 kB
`build/reviews-by-product.js`	12.3 kB
`build/reviews-frontend.js`	7.14 kB
`build/single-product-frontend.js`	17.8 kB
`build/single-product.js`	9.98 kB
`build/stock-filter-frontend.js`	21.1 kB
`build/stock-filter-wrapper-frontend.js`	5.86 kB
`build/stock-filter.js`	8.13 kB
`build/store-notices.js`	1.65 kB
`build/vendors--attribute-filter-wrapper--cart-blocks/cart-cross-sells-products--cart-blocks/order-summary--82e4ed06-frontend.js`	6.86 kB
`build/vendors--attribute-filter-wrapper--rating-filter-wrapper--stock-filter-wrapper-frontend.js`	7.7 kB
`build/vendors--cart-blocks/cart-cross-sells-products--cart-blocks/cart-line-items--cart-blocks/cart-order--3c5fe802-frontend.js`	5.26 kB
`build/vendors--cart-blocks/cart-cross-sells-products--cart-blocks/order-summary-shipping--checkout-blocks--18f9376a-frontend.js`	19.4 kB
`build/vendors--cart-blocks/cart-cross-sells-products--product-add-to-cart-frontend.js`	7.53 kB
`build/vendors--cart-blocks/cart-line-items--checkout-blocks/order-summary-cart-items--mini-cart-contents---233ab542-frontend.js`	3.14 kB
`build/vendors--cart-blocks/order-summary-shipping--checkout-blocks/billing-address--checkout-blocks/order--5b8feb0b-frontend.js`	4.83 kB
`build/vendors--checkout-blocks/shipping-method-frontend.js`	12 kB
`build/vendors--checkout-blocks/shipping-methods-frontend.js`	9.48 kB
`build/wc-blocks-data.js`	21.9 kB
`build/wc-blocks-editor-style-rtl.css`	5.47 kB
`build/wc-blocks-editor-style.css`	5.47 kB
`build/wc-blocks-google-analytics.js`	1.56 kB
`build/wc-blocks-middleware.js`	933 B
`build/wc-blocks-registry.js`	3.16 kB
`build/wc-blocks-shared-context.js`	1.52 kB
`build/wc-blocks-shared-hocs.js`	1.73 kB
`build/wc-blocks-style-rtl.css`	25.7 kB
`build/wc-blocks-style.css`	25.7 kB
`build/wc-blocks-vendors-style-rtl.css`	1.96 kB
`build/wc-blocks-vendors-style.css`	1.96 kB
`build/wc-blocks-vendors.js`	64.3 kB
`build/wc-blocks.js`	2.63 kB
`build/wc-payment-method-bacs.js`	816 B
`build/wc-payment-method-cheque.js`	811 B
`build/wc-payment-method-cod.js`	909 B
`build/wc-payment-method-paypal.js`	837 B
`build/wc-settings.js`	2.6 kB
`build/wc-shipping-method-pickup-location.js`	29.7 kB
`build/wp-directives-runtime.js`	2.4 kB
`build/wp-directives-vendors.js`	7.89 kB

_{compressed-size-action}

danielwrobert

Everything tests as described. I also confirmed the the <FormattedMonetaryAmount /> component does not accept an isLoading prop and the expected behavior remains in-tact when removing it.

Nice work on this! 🚀

Remove unneeded isloading attribute

4d0c413

woocommercebot requested review from a team and danielwrobert and removed request for a team January 30, 2023 21:44

roykho added focus: blocks Specific work involving or impacting how blocks behave. block: filter by price Issues related to the Filter by Price block. labels Feb 2, 2023

danielwrobert approved these changes Feb 2, 2023

View reviewed changes

github-actions bot added this to the 9.6.0 milestone Feb 2, 2023

github-actions bot added the status: ready to merge label Feb 2, 2023

roykho merged commit 7cb865e into trunk Feb 2, 2023

roykho deleted the fix/price-filter-isloading branch February 2, 2023 17:35

github-actions bot removed the status: ready to merge label Feb 2, 2023

tarhi-saad added the type: bug The issue/PR concerns a confirmed bug. label Feb 14, 2023

tarhi-saad mentioned this pull request Feb 16, 2023

Update WooCommerce blocks package to 9.6.1 woocommerce/woocommerce#36852

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove unneeded isloading attribute #8340

Remove unneeded isloading attribute #8340

roykho commented Jan 30, 2023

github-actions bot commented Jan 30, 2023 •

edited

Loading

github-actions bot commented Jan 30, 2023

danielwrobert left a comment

Remove unneeded isloading attribute #8340

Remove unneeded isloading attribute #8340

Conversation

roykho commented Jan 30, 2023

Testing

User Facing Testing

Performance Impact

Changelog

github-actions bot commented Jan 30, 2023 • edited Loading

Script Dependencies Report

TypeScript Errors Report

github-actions bot commented Jan 30, 2023

danielwrobert left a comment

Choose a reason for hiding this comment

github-actions bot commented Jan 30, 2023 •

edited

Loading